nas-samba v2.0.0: persist Samba TDB, fix startup user migration

apps/nas-samba/source/app/server.js

@@ -1675,12 +1675,24 @@ function main() {
     // Seed admin
     seedAdmin();
 
-    // Ensure existing users have home directories (migration support)
+    // Re-create Linux users and ensure Samba accounts on every startup
     const existingUsers = sqlDb.prepare('SELECT username FROM users').all();
     for (const u of existingUsers) {
       const homeDir = path.join(HOME_BASE, u.username);
-      if (!fs.existsSync(homeDir)) {
-        fs.mkdirSync(homeDir, { recursive: true });
+      fs.mkdirSync(homeDir, { recursive: true });
+      try {
+        execSync(`id -u "${u.username}" >/dev/null 2>&1 || useradd -M -s /usr/sbin/nologin "${u.username}"`);
+        execSync(`chown "${u.username}":nogroup "${homeDir}"`);
+        // Set Samba password only if user not already in TDB (first run or migration)
+        try {
+          execSync(`pdbedit -u "${u.username}" >/dev/null 2>&1`);
+        } catch (_e) {
+          const escaped = ADMIN_PASSWORD.replace(/'/g, "'\\''");
+          execSync(`printf '%s\\n%s\\n' '${escaped}' '${escaped}' | smbpasswd -a -s "${u.username}"`);
+          console.log(`Samba account created for ${u.username} (using SMB_PASSWORD)`);
+        }
+      } catch (err) {
+        console.error(`Failed to ensure system user ${u.username}:`, err.message);
       }
     }