From 0ffb0f725600c33ea3eccf2c824efb5abc5c902f Mon Sep 17 00:00:00 2001
From: alexz <me@alexzaw.dev>
Date: Mon, 9 Mar 2026 18:18:15 +0000
Subject: [PATCH] fix: use hostPort string format for IP binding, remove hostIp
 field

---
 apps/nas-samba/config.json         |  8 --------
 apps/nas-samba/docker-compose.json | 12 ++++--------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/apps/nas-samba/config.json b/apps/nas-samba/config.json
index 18ea517..b2bd79b 100644
--- a/apps/nas-samba/config.json
+++ b/apps/nas-samba/config.json
@@ -28,14 +28,6 @@
       "required": true,
       "default": "/nas",
       "hint": "Host path to share via SMB"
-    },
-    {
-      "type": "text",
-      "label": "Bind IP",
-      "env_variable": "BIND_IP",
-      "required": true,
-      "default": "192.168.0.15",
-      "hint": "IP address to bind SMB ports to"
     }
   ],
   "supported_architectures": ["arm64", "amd64"],
diff --git a/apps/nas-samba/docker-compose.json b/apps/nas-samba/docker-compose.json
index 3cb3e91..afdffad 100644
--- a/apps/nas-samba/docker-compose.json
+++ b/apps/nas-samba/docker-compose.json
@@ -9,16 +9,12 @@
       "hostname": "nas",
       "addPorts": [
         {
-          "hostPort": 445,
-          "containerPort": 445,
-          "protocol": "tcp",
-          "hostIp": "${BIND_IP:-192.168.0.15}"
+          "hostPort": "192.168.0.15:445",
+          "containerPort": 445
         },
         {
-          "hostPort": 139,
-          "containerPort": 139,
-          "protocol": "tcp",
-          "hostIp": "${BIND_IP:-192.168.0.15}"
+          "hostPort": "192.168.0.15:139",
+          "containerPort": 139
         }
       ],
       "volumes": [