fix: prevent Chromium zombie leak in htmlToPdf

- Wrap browser lifecycle in try/finally so browser.close() always runs
- Fall back to SIGKILL of browser.process() if close() fails
- Add --disable-dev-shm-usage to launch args (container stability)
- Add tini as ENTRYPOINT in Dockerfile for defense in depth
- Bump version to 1.0.2
This commit is contained in:
alexz
2026-04-11 14:59:50 +00:00
parent 6cac4d16e0
commit 43152351fa
3 changed files with 45 additions and 34 deletions

View File

@@ -4,6 +4,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
chromium \
fonts-freefont-ttf \
fonts-noto-cjk \
tini \
&& rm -rf /var/lib/apt/lists/*
WORKDIR /app
@@ -21,4 +22,5 @@ EXPOSE 3000
HEALTHCHECK --interval=30s --timeout=5s --retries=3 \
CMD node -e "require('http').get('http://localhost:3000/health', r => process.exit(r.statusCode === 200 ? 0 : 1))"
ENTRYPOINT ["/usr/bin/tini", "--"]
CMD ["node", "server.js"]

View File

@@ -235,8 +235,9 @@ async function htmlToPdf(html) {
const browser = await puppeteer.launch({
executablePath: process.env.CHROME_PATH || "/usr/bin/google-chrome-stable",
args: ["--no-sandbox", "--disable-setuid-sandbox"],
args: ["--no-sandbox", "--disable-setuid-sandbox", "--disable-dev-shm-usage"],
});
try {
const page = await browser.newPage();
const htmlForPdf = html.replace(
@@ -270,8 +271,16 @@ async function htmlToPdf(html) {
printBackground: true,
margin: { top: "20mm", bottom: "20mm", left: "15mm", right: "15mm" },
});
await browser.close();
return pdfBuffer;
} finally {
try {
await browser.close();
} catch (e) {
try {
browser.process()?.kill("SIGKILL");
} catch (_) {}
}
}
}
module.exports = { markdownToHtml, htmlToPdf };

View File

@@ -1,6 +1,6 @@
{
"name": "md2html",
"version": "1.0.0",
"version": "1.0.2",
"description": "",
"main": "index.js",
"scripts": {