alexz/arena-plm-fiori
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ADR-004: back out of on-stack RAP; retarget to starter customizing tenant

Browse Source 
Both tenants belong to the same starter system: my429480 is its
customizing tenant (client 100, key-user extensibility only, no ABAP)
and my431353 is its development tenant (client 080). This package had
recorded my429480 as "productive" and ADR-002 had assumed it offered
developer extensibility; both were wrong.

- ADR-004 withdraws the on-stack RAP route and moves the application to
  a side-by-side runtime against released OData APIs. ADR-002 marked
  superseded.
- Development tenant my431353 parked: all 19 ZARENA_PLM objects left
  active, sources kept in docs/handover/rap/ as reference, so the route
  stays reversible.
- Replacement host left open as OQ-11 (key-user extensibility vs CAP
  side-by-side); recommendation recorded as CAP. No build starts until
  OQ-11 is closed.
- RAP-dependent items V-2, V-3, OQ-5, OQ-8, OQ-9, OQ-10 parked rather
  than closed.
- Tenant references corrected across CLAUDE.md, KNOWLEDGE.md,
  app/README.md, the RAP handover README, the rap-developer agent and
  the reentrance-login helper README.

No SAP tenant was modified.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
alexz
2026-09-29 10:33:29 -07:00
co-authored by Claude Opus 5
parent 468729eb4e
commit ffd33f4ec0
10 changed files with 332 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+65 -27
View File
@@ -6,23 +6,50 @@
## What this is
Approval-gated sync of Arena PLM items into SAP S/4HANA Public Cloud
(`my429480.s4hana.cloud.sap` productive; development tenant `my431353.s4hana.cloud.sap` since 2026-09-15 — API-only tenants: no RFC, no custom IDocs):
materials, BOMs, change masters, documents. Standalone successor to the Express
Approval-gated sync of Arena PLM items into SAP S/4HANA Public Cloud:
materials, BOMs, change masters, documents.
Both tenants named in this repo belong to the **same starter system**. The
working target is the starter system's **customizing tenant**
`my429480.s4hana.cloud.sap` (client 100 — key-user extensibility and
configuration only; no ABAP, no RAP). The starter system's **development
tenant** `my431353.s4hana.cloud.sap` (client 080 — developer extensibility) is
**parked as of 2026-09-29**, with the objects I built there left in place. Both
tenants are API-only: no RFC, no custom IDocs.
Standalone successor to the Express
implementation at `~/projects/sap-apps/arena-plm`, which is **reference-only**
— consult it for behavior, never extend it.
## Architecture (ADR-002, 2026-09-04 — on-stack first)
## Architecture (ADR-004, 2026-09-29 — side-by-side against released APIs)
The application lives **in the tenant**: a custom RAP business object for the
approval domain, a Fiori Elements app in the tenant's Fiori launchpad, IAM
app / business catalog / business roles as the only access control, and custom
CDS views for discoverability. Side-by-side is reduced to one hardened
TypeScript **connectivity worker** (Arena webhook/poll/session/files + initial
sync executor) — machine-to-machine only, no UI, no user-facing URLs.
The on-stack RAP route of ADR-002 is **withdrawn and superseded**. The starter
system's customizing tenant `my429480` (client 100) supports key-user
extensibility only — no ABAP, no RAP — so the custom RAP business object ADR-002
called for has no home in the tenant I work in.
The acceptance test: a business user finds the app in the Fiori launchpad and
its data in the Custom CDS Views app. Anything that fails that test is not done.
The application therefore runs **side-by-side against released OData APIs**,
with the customizing tenant as the sync target and configuration home. The
replacement host is deliberately left **open as OQ-11**: key-user extensibility
in the customizing tenant (custom business object plus a low-code UI) versus a
CAP service side-by-side on BTP. My recommendation is **CAP** — the
connectivity worker has to live side-by-side whatever else happens, and one
runtime beats two. **No build starts until OQ-11 is closed.**
Kept, unchanged in value: the hardened TypeScript **connectivity worker**
(Arena webhook/poll/session/files + initial sync executor) — machine-to-machine
only, no UI, no user-facing URLs, and needed under either OQ-11 option — and
the Fiori Elements app in `app/`, which is repointable.
**Parked reference, not deleted:** the RAP approval business object I built on
the starter system's development tenant `my431353` (client 080). All 19
`ZARENA_PLM` objects are left active there and their sources stay in
`docs/handover/rap/`, so that route stays reversible at zero cost.
The acceptance test, as amended by ADR-004: a business user finds the
application from the S/4HANA launchpad and access is governed by business
roles. The "its data in the Custom CDS Views app" clause is withdrawn — it is
unreachable from client 100.
## Operating rules
@@ -59,20 +86,24 @@ its data in the Custom CDS Views app. Anything that fails that test is not done.
| RAP guides, extensibility docs, SAP Help / Community | `sap-docs` |
| Is this SAP object released for ABAP Cloud? Successors? | `sap-released-objects` |
| Fiori Elements, `@UI` annotations, manifest | `fiori-mcp-server` |
| Writing objects INTO the development tenant (create/activate/transport/ATC/unit tests) | `adt-mcp` — SAP ADT MCP Server from `sapse.adt-vscode`, `http://127.0.0.1:2236/mcp`; bearer token lives in `~/.vscode-server/data/Machine/settings.json` and changes on VS Code reload — refresh `.mcp.json` then |
| Writing objects INTO the starter system's development tenant (create/activate/transport/ATC/unit tests) — **parked 2026-09-29 with that tenant** | `adt-mcp` — SAP ADT MCP Server from `sapse.adt-vscode`, `http://127.0.0.1:2236/mcp`; bearer token lives in `~/.vscode-server/data/Machine/settings.json` and changes on VS Code reload — refresh `.mcp.json` then |
| UI5 controls/views (only if custom UI proves necessary) | `ui5-mcp-server` |
When MCP guidance conflicts with training knowledge, follow MCP.
Live system checks from this box (verified 2026-09-15): the `sap-api` CLI
(`/usr/local/bin/sap-api`) reaches the **development** tenant `my431353` by
default (credentials in `~/projects/sap-integrations/_shared/.env`; the
productive credential is `.env.prod-my429480.bak`) and Arena — API catalog search,
Live system checks from this box: as of 2026-09-29 the `sap-api` CLI
(`/usr/local/bin/sap-api`) reaches the starter system's **customizing tenant**
`my429480` by default (credentials in
`~/projects/sap-integrations/_shared/.env`; the parked development-tenant
credential is `.env.starter-dev-my431353.bak` and the customizing-tenant copy is
`.env.starter-cust-my429480.bak`, both in the same folder) and Arena — API catalog search,
EDMX fetch, OpenAPI generation (`sap-api apis generateOpenapi --service …`),
communication arrangements (`comm`), user/role admin (`users`), and read paths
for the released business APIs and Arena items. Read commands are fair game
for design and acceptance; mutating commands are delegated like any other
write.
write. The retarget is in place, but the `my429480` credential itself answered
HTTP 401 ("Anmeldung fehlgeschlagen") on 2026-09-29 — it needs refreshing before
any CLI call against that tenant succeeds.
## Delegation (project agents in `.claude/agents/`)
@@ -83,20 +114,27 @@ verified sources: `docs/agent-roster.md`.
| Work | Agent |
|---|---|
| On-stack ABAP Cloud: RAP BO, CDS, behavior, IAM artifacts | `rap-developer` |
| On-stack ABAP Cloud: RAP BO, CDS, behavior, IAM artifacts — **dormant** while the RAP route is parked (ADR-004) | `rap-developer` |
| Fiori Elements app, `@UI` annotations, manifest, launchpad | `fiori-developer` |
| TS connectivity worker: Arena API, Cloud SDK OData writes | `worker-developer` |
| Read-only SAP review: clean core, contracts, tombstones | `sap-code-reviewer` |
| Tests for worker + service layers | `test-engineer` |
## Repo state & commands (verified 2026-09-14)
## Repo state & commands (verified 2026-09-29)
Implementation so far: the TypeScript connectivity worker in `worker/`
(Fastify surface + Arena session core; sync executors are stubs until V-2).
The on-stack RAP track has no code yet — gated on V-1. The Fiori Elements app
(`app/`, TypeScript) is scaffolded against a **mock** OData V4 service:
`npm run start-mock` serves it on port 8082; its service identity is
provisional until reconciled with the live RAP UI binding at V-2.
Nothing in this package has ever been deployed or reached a business user, and
no build resumes until OQ-11 is closed. What exists:
- `worker/` — the TypeScript connectivity worker (Fastify surface + Arena
session core; sync executors are stubs). Built, 137 tests green, never
deployed. Needed under either OQ-11 option.
- `app/` — the Fiori Elements app (TypeScript), bound to a **mock** OData V4
service: `npm run start-mock` serves it on port 8082. Its service identity is
provisional; it gets repointed once OQ-11 names the host.
- `docs/handover/rap/` — the sources for the 19 `ZARENA_PLM` objects I
activated on the starter system's development tenant `my431353`, parked
2026-09-29 with the objects left in place. Reference and a reversible route,
not a live track.
In `worker/`: `npm run build` (tsc), `npm run lint` (eslint), `npm test`
(vitest), `npm run dev` (tsx watch). The worker's HTTP surface is governed by
@@ -109,7 +147,7 @@ In `worker/`: `npm run build` (tsc), `npm run lint` (eslint), `npm test`
| `PRD.md` | Living requirements, target architecture, contracts, verification items |
| `CHANGELOG.md` | Append-only decision log |
| `KNOWLEDGE.md` | Dated tombstones & landmines — the only knowledge carried from the predecessor; also check it when anything unexpected appears in the repo |
| `docs/adr/` | Architecture decision records (ADR-001 amended by ADR-002) |
| `docs/adr/` | Architecture decision records (ADR-004 supersedes ADR-002 and partly revives ADR-001) |
| `docs/agent-roster.md` | Specialist-agent design + verified sources |
| `docs/predecessor-flow.md` | How the Express predecessor actually works (extracted 2026-09-10) — read before designing executor, poller, or approval behavior |
| `.claude/hooks/` | ADR-003 enforcement scripts (grounding injections, consult gate, consult marker); `tests/run.sh` pipe-tests them — run it after any hook change |