upload current sources

2026-09-16 01:47:28 -07:00
commit f8b45ea4a5
109 changed files with 26012 additions and 0 deletions
@@ -0,0 +1,64 @@
+# Specialist Agent Roster — founding-kit design
+
+Compiled 2026-09-04 from a 4-agent verified research sweep (3 researchers +
+1 adversarial verifier; 37 findings, 22 confirmed, 14 downgraded/refuted and
+discarded). Every design choice below cites a CONFIRMED source. This is the
+"dedicated agents" layer of the founding kit; the files live in
+`.claude/agents/`.
+
+## Design principles (adopted from confirmed sources)
+
+1. **Tool restrictions enforce role — prompts merely request it.** A reviewer
+   without Write cannot introduce bugs; a test agent without deploy tools
+   cannot ship. [source: https://www.pubnub.com/blog/best-practices-for-claude-code-sub-agents/ + https://github.com/VoltAgent/awesome-claude-code-subagents, verified 2026-09-04]
+2. **Every agent carries the MCP routing table for its artifacts** — the
+   pattern SAP itself demonstrates in its official agentic CAP reference app
+   (AGENTS.md maps each artifact type to its grounding server). [source: https://github.com/SAP-samples/cap-agentic-engineered, verified 2026-09-04]
+3. **Model per role:** implementation agents inherit the session model;
+   the test agent runs on Haiku (cheap, mechanical work). [source: https://github.com/lst97/claude-code-sub-agents test-automator pattern — repo verified WEAK on scale claims but the model-tiering pattern confirmed on page, 2026-09-04]
+4. **Reviewer filters false positives explicitly** (excluded classes declared
+   up front), per Anthropic's own security-review agent. [source: https://github.com/anthropics/claude-code-security-review, verified 2026-09-04]
+5. All agents inherit this repo's enforcement layer (ADR-003 gate + citation
+   duty) automatically — hooks are project-scoped, so no per-agent wiring.
+
+## The roster (5 — the cap)
+
+| Agent | Scope | Tools (restriction is the contract) | Model |
+|---|---|---|---|
+| `rap-developer` | On-stack ABAP Cloud: RAP BO, CDS, behavior, BDEF, IAM artifacts | Edit/Write/Read/Grep/Glob/Bash + abap-docs, sap-docs, sap-released-objects | inherit |
+| `fiori-developer` | Fiori Elements app, annotations, manifest, launchpad content | Edit/Write/Read/Grep/Glob/Bash + fiori-mcp-server (3-step workflow), ui5-mcp-server | inherit |
+| `worker-developer` | TS connectivity worker: Arena API, Cloud SDK OData writes | Edit/Write/Read/Grep/Glob/Bash + context7 | inherit |
+| `sap-code-reviewer` | Clean-core, security, contract conformance review | **Read/Grep/Glob + doc MCPs only — no Write, no Bash** | inherit |
+| `test-engineer` | Unit/integration tests for worker + service layers | Edit/Write/Read/Grep/Glob/Bash (test commands only by instruction) | haiku |
+
+## MCP additions (recommended, gated — not installed)
+
+The on-stack RAP work needs an **ADT MCP server** (live syntax check, ATC,
+activation, repository objects). Verified options, in preference order per the
+prefer-standard rule:
+
+1. **SAP's official ABAP MCP path** — SAP's agentic-ABAP direction (VS Code
+   ADT + zero-config MCP) is announced and rolling out; `sapse.adt-vscode` is
+   already installed on this machine. Evaluate first at V-1.
+   [source: https://community.sap.com/t5/technology-blog-posts-by-sap/entering-the-new-era-of-agentic-ai-for-abap-development/ba-p/14394643 + community post ba-p/14408186, verified 2026-09-04]
+2. **ARC-1** (`arc-mcp/arc-1`) — enterprise ABAP/ADT MCP, maintained.
+   [source: https://github.com/arc-mcp/arc-1, verified 2026-09-04]
+3. **`yzonur/sap-adt-mcp`** — 27 ADT tools incl. quality gates, read-only
+   flag, audit logging. [source: https://github.com/yzonur/sap-adt-mcp, verified 2026-09-04]
+
+Optional later: SAP's official **BTP Administration MCP** for the devops side.
+[source: https://community.sap.com/t5/technology-blog-posts-by-sap/public-release-of-the-mcp-server-for-sap-btp-administration/ba-p/14471692, verified 2026-09-04]
+
+Registry for future discovery: https://github.com/marianfoo/sap-ai-mcp-servers
+(verified 2026-09-04). Note: `marianfoo/mcp-sap-notes` is archived (June 2026),
+superseded by `marianfoo/sap-mcp-servers` — do not adopt the archived one.
+
+## Discarded by verification (recorded so they are not re-researched)
+
+- `MariusAlbrecht/mcp-adt` — does not exist (404; the real ADT bridge is the
+  separate "vs-punk" project).
+- SAP GUI automation MCP — cited listing 404s; GUI automation irrelevant to
+  Public Cloud anyway.
+- `rap-skills`, `claude-abap-skills` — real but 1–14 commits; mine their
+  *scenario decomposition ideas* (generator/CDS/behavior/testing/troubleshoot),
+  do not depend on the repos.